[Logwatch-Devel] smartd patch

Mike Tremaine mgt at stellarcore.net
Tue Feb 7 21:59:44 MST 2006


On Tue, 2006-02-07 at 14:28 -0800, Mark Nienberg wrote:
> Apologies if this is a duplicate msg.  I think my first attempt bounced.
> 
> The attached patch for the smartd service provides the following 
> enhancements:
> 
> First, it lists the changes in parameters in the correct order and 
> doesn't leave any out. This allows you to see the trend (if there is 
> one).  For example:
> 
> /dev/twa0 [3ware_disk_01] :
>      Usage: SomeAttribute (190) changed to
>        98, 99, 97, 99, 98, 97, 96, 97,
> 
> The old version would sort these and remove duplicates, which made it 
> appear that the values were always rising.  For example, it would yield: 
> 96, 97, 98, 99 for the above example, which gives the wrong impression.
> 
> 
> Second, it reports on Failed attributes separately, like this:
> 
> /dev/twa0 [3ware_disk_02] :
>      Failed usage attribute: SomeAttribute (190) 10 Time(s)
> 
> 
> Third, it reports self tests like this:
> 
> /dev/twa0 [3ware_disk_00] :
>      started scheduled Long self-test 1 Time(s)
>      started scheduled Short self-test 2 Time(s)
> 
> Finally, it cleans up a couple more unrecognized lines.
> 

This has been committed to CVS... Thanks Mark!

-Mike



More information about the Logwatch-Devel mailing list